[CUDAX] Add assignment operator that rebinds resource_ref #6240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pciolkosz
changed the title
This comment has been minimized.
This comment has been minimized.
davebayer
approved these changes
Oct 15, 2025
This comment has been minimized.
This comment has been minimized.
…nment_to_resource_ref
🥳 CI Workflow Results🟩 Finished in 40m 40s: Pass: 100%/42 | Total: 8h 14m | Max: 26m 20s | Hits: 82%/21477See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
operator=to the experimental[synchronous_]resource_refwhich rebinds the reference. The previous implementation that is currently in libcu++ supported it and RMM requested we should support the assignment.We discussed this in the past and decided to implement the assignment in the resource wrappers, not in
basic_anyTesting for the assignment is very light, because I will be moving the type erased wrappers to libcu++ soon and there is more testing for
resource_refassignment implemented there